feat: allow initialising project with custom package name with init --package-name
#1808
Conversation
|
Can we have some tests for this? |
TMisiukiewicz
force-pushed
the
feat/package-name
branch
from
861e3f0 to
515b6d3
Compare
| name: '--package-name <string>', | ||
| description: | ||
| 'Inits a project with a custom package name (Android) and bundle ID (iOS), e.g. com.example.app', | ||
| }, |
There was a problem hiding this comment.
Let's add this to docs 😄
tests added ✅ |
| fs.rename( | ||
| `${filePath}/${segmentsList.join('.')}`, | ||
| `${filePath}/${segmentsList[segmentsList.length - 1]}`, | ||
| ); | ||
|
|
||
| for (const segment of segmentsList) { | ||
| fs.mkdirSync(segment); | ||
| process.chdir(segment); | ||
| } | ||
|
|
||
| fs.rename( | ||
| `${filePath}/${segmentsList[segmentsList.length - 1]}`, | ||
| process.cwd(), | ||
| ); |
There was a problem hiding this comment.
Those renames can fail and createAndroidPackagePaths also isn't guarded by try/catch, so the user would be left blind when fs.rename throws. Please make sure to guard this case
thymikee
changed the title
init --package-name
TMisiukiewicz
force-pushed
the
feat/package-name
branch
from
51e8128 to
3f8e712
Compare
|
can we have an example for this? I tried this npx react-native@latest init [APP_NAME] --package-name [PACKAGE_NAME] --title [APP_TITLE]but it doesn't work |
|
Hey @bryanltobing, what error you get if you try this command? And also could you please provide output from |
|
it does work now. sorry for the inconvenient |
|
packages only can start by "com"? can be changed as user sets? for example if domain start with "org" or by country domain |
|
hi @javier8340, it was fixed in #1915 |
Summary:
Closes #1269
Relates to #1111
Added
--package-nameoption toinitcommand, which allows initialising project with custom package name for Android and iOS.Test Plan:
Use
initcommand with--package-nameoption:example,[email protected]--package-name example.app- project should be initialised withcom.example.appAndroid package name and iOS bundleID--package-name com.example.app- project should be initialised withcom.example.appAndroid package name and iOS bundleIDFor 2. and 3., app should be installed on the device/emulator named by project name - not package name.