-
Notifications
You must be signed in to change notification settings - Fork 906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: ruby version check for RN CLI Doctor #1818
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally and all works as expected :)
|
||
logManualInstallation({ | ||
healthcheck: 'Ruby', | ||
url: 'https://reactnative.dev/docs/environment-setup#ruby', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@arushikesarwani, when I go to https://reactnative.dev/docs/environment-setup#ruby it only takes me to the correct place if I have previously opened the "React Native CLI Quickstart" tab (and all the other tabs underneath it) and the Ruby heading is visible. Otherwise it is a broken link.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, unfortunately, that's a problem with the current website and how docusaurus handles deeplink with tabs. I think we need to change the website design to ease the usage of links with anchors like this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, unfortunately, that's a problem with the current website and how docusaurus handles deeplink with tabs. I think we need to change the website design to ease the usage of links with anchors like this.
Think its related to #1767
Summary:
Adding the check for Ruby version required for React Native app.
Minimum version needed >= 2.7.6
Test Plan:
node ./scripts/build.js && yarn build:debugger
yarn link
yarn link "@react-native-community/cli-doctor"
npx @react-native-community/cli doctor
Before :
After :
WARNING -
SUCCESS -