feat: extract android applicationId #1951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamTrz
force-pushed
the
feat/android-applicationId
branch
from
6ae39f6 to
ddb3884
Compare
cortinico
approved these changes
Jun 2, 2023
packages/cli-platform-android/src/commands/runAndroid/tryLaunchAppOnDevice.ts
Outdated
Show resolved
Hide resolved
packages/cli-platform-android/src/config/__fixtures__/files/build.gradle
Outdated
Show resolved
Hide resolved
szymonrybczak
force-pushed
the
feat/android-applicationId
branch
from
c451ca7 to
485f79f
Compare
cortinico
reviewed
Jun 15, 2023
packages/cli/src/index.ts
Outdated
| .option('--verbose', 'Increase logging verbosity') | ||
| .enablePositionalOptions(); | ||
| .option('--verbose', 'Increase logging verbosity'); | ||
| // .enablePositionalOptions(); |
There was a problem hiding this comment.
did you intend to remove this line?
There was a problem hiding this comment.
Nah. That should be reverted 👌
TMisiukiewicz
approved these changes
Jun 21, 2023
adamTrz
force-pushed
the
feat/android-applicationId
branch
from
750f2e6 to
c57f6b1
Compare
|
thank you for great works! how to use that ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Use
applicationIdspecified indefaultConfigofbuild.gradefile.Fixes #1884
Test Plan:
applicationIdinsidedefaultConfigofbuild.gradlefile, eg.namespace "com.foo" defaultConfig { + applicationId "com.bar" - applicationId "com.foo"TODO's / things to consider 🤔 :
appldpresent atdefaultConfigobject inbuild.gradlefile. Should we default then to namespace?