-
Notifications
You must be signed in to change notification settings - Fork 906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ios): fix crash when --mode
is specified
#1958
fix(ios): fix crash when --mode
is specified
#1958
Conversation
Assumptions about where the `.xcodeproj` lives causes `checkIfConfigurationExists` to crash because `undefined` was passed as project.
import {IosProjectInfo} from '../types'; | ||
|
||
export function checkIfConfigurationExists( | ||
project: IosProjectInfo, | ||
mode: string, | ||
) { | ||
if (!project) { | ||
logger.warn(`Unable to check whether "${mode}" exists in your project`); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know if this warning is actually useful. I'd prefer to not have it here, but I'll let you decide.
Super strange that example workspace don't have |
That is because the CLI is trying to look for |
Yeah, got it. Still, one would hope that I'll try to look at your PR ASPA, seems like |
Assumptions about where the `.xcodeproj` lives causes `checkIfConfigurationExists` to crash because `undefined` was passed as project.
Summary:
Assumptions about where the
.xcodeproj
lives causescheckIfConfigurationExists
to crash becauseundefined
was passed as project.Test Plan:
The last command should not crash.