Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

breaking: remove --configuration option from build/run-ios #2028

Merged
merged 1 commit into from
Aug 9, 2023
Merged

breaking: remove --configuration option from build/run-ios #2028

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions packages/cli-platform-ios/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,10 +43,6 @@ Example: this will launch your project directly onto the iPhone 14 simulator:
react-native run-ios --simulator "iPhone 14"
```

#### `--configuration <string>`

[Deprecated] Explicitly set the scheme configuration to use default: 'Debug'.

#### `--mode <string>`

Explicitly set the scheme configuration to use. This option is case sensitive.
Expand Down Expand Up @@ -141,10 +137,6 @@ Example: this will launch your project directly onto the iPhone 14 simulator:
react-native build-ios --simulator "iPhone 14"
```

#### `--configuration <string>`

[Deprecated] Explicitly set the scheme configuration to use default: 'Debug'.

#### `--mode <string>`

Explicitly set the scheme configuration to use. This option is case sensitive.
Expand Down
13 changes: 0 additions & 13 deletions packages/cli-platform-ios/src/commands/buildIOS/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ import {getConfigurationScheme} from '../../tools/getConfigurationScheme';
import listIOSDevices from '../../tools/listIOSDevices';

export interface FlagsT extends BuildFlags {
configuration?: string;
simulator?: string;
device?: string | true;
udid?: string;
Expand All @@ -48,14 +47,6 @@ async function buildIOS(_: Array<string>, ctx: Config, args: FlagsT) {

process.chdir(sourceDir);

if (args.configuration) {
logger.warn('--configuration has been deprecated. Use --mode instead.');
logger.warn(
'Parameters were automatically reassigned to --mode on this run.',
);
args.mode = args.configuration;
}

const projectInfo = getProjectInfo();

if (args.mode) {
Expand Down Expand Up @@ -215,10 +206,6 @@ export const iosBuildOptions = [
description:
'Explicitly set the scheme configuration to use. This option is case sensitive.',
},
{
name: '--configuration <string>',
description: '[Deprecated] Explicitly set the scheme configuration to use',
},
{
name: '--scheme <string>',
description: 'Explicitly set Xcode scheme to use',
Expand Down
15 changes: 3 additions & 12 deletions packages/cli-platform-ios/src/commands/runIOS/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ import getSimulators from '../../tools/getSimulators';

export interface FlagsT extends BuildFlags {
simulator?: string;
configuration: string;
scheme?: string;
projectPath: string;
device?: string | true;
Expand Down Expand Up @@ -70,14 +69,6 @@ async function runIOS(_: Array<string>, ctx: Config, args: FlagsT) {
}
}

if (args.configuration) {
logger.warn('--configuration has been deprecated. Use --mode instead.');
logger.warn(
'Parameters were automatically reassigned to --mode on this run.',
);
args.mode = args.configuration;
}

const projectInfo = getProjectInfo();

if (args.mode) {
Expand Down Expand Up @@ -293,7 +284,7 @@ async function runOnSimulator(

appPath = await getBuildPath(
xcodeProject,
args.mode || args.configuration,
args.mode,
buildOutput,
scheme,
args.target,
Expand Down Expand Up @@ -375,7 +366,7 @@ async function runOnDevice(

const appPath = await getBuildPath(
xcodeProject,
args.mode || args.configuration,
args.mode,
buildOutput,
scheme,
args.target,
Expand All @@ -398,7 +389,7 @@ async function runOnDevice(

appPath = await getBuildPath(
xcodeProject,
args.mode || args.configuration,
args.mode,
buildOutput,
scheme,
args.target,
Expand Down