Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli-plugin-metro): ensure bundle destination directory exist #2040

Merged

Conversation

tido64
Copy link
Contributor

@tido64 tido64 commented Jul 31, 2023

Summary:

react-native bundle currently fails if the bundle destination directory does not exist.

Example:

% yarn react-native bundle --entry-file index.js --platform android --dev true --bundle-output dist/main.android.jsbundle --assets-dest dist/res
                Welcome to Metro v0.73.10
              Fast - Scalable - Integrated


info Writing bundle output to:, dist/main.android.jsbundle
error ENOENT: no such file or directory, open 'dist/main.android.jsbundle'.
Error: ENOENT: no such file or directory, open 'dist/main.android.jsbundle'

Test Plan:

Run react-native bundle before and after applying the changes in any app. In my case, I used react-native-test-app.

Checklist

  • Documentation is up to date to reflect these changes.
  • Follows commit message convention described in CONTRIBUTING.md

@tido64 tido64 requested review from adamTrz and thymikee as code owners July 31, 2023 11:07
Copy link
Collaborator

@szymonrybczak szymonrybczak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@thymikee thymikee merged commit 48d4c29 into react-native-community:main Aug 9, 2023
@tido64 tido64 deleted the tido/ensure-dest-exists branch August 9, 2023 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants