fix: improve providing project name in init command
#2071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szymonrybczak
changed the title
init command
thymikee
reviewed
Sep 11, 2023
| const {projName} = await prompts({ | ||
| type: 'text', | ||
| name: 'projName', | ||
| message: 'What is the project name?', |
There was a problem hiding this comment.
Would that wording make sense?
Suggested change
| message: 'What is the project name?', | |
| message: 'How would you like to name the app?', |
Also, how about adding a hint guiding the user on what is about to happen? Something like:
New app will be initialized in the directory of the same name. Android and iOS projects will use this name for publishing setup
If this wording works, we can also reflect it in the command description
There was a problem hiding this comment.
Also, how about adding a hint guiding the user on what is about to happen? Something like:
Fun fact: when using type: 'text' prompt, we cannot show the hint 🙈
If this wording works, we can also reflect it in the command description
Done ✅
szymonrybczak
force-pushed
the
fix/improve-providing-project-name
branch
from
1273a28 to
951b2de
Compare
thymikee
approved these changes
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Closes #2063
Test Plan:
Should prompt user for the project name.
Checklist