Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade Android Studio version when installing on Windows #2072

Merged
merged 1 commit into from
Sep 20, 2023

Conversation

szymonrybczak
Copy link
Collaborator

Summary:

#2068

Test Plan:

  1. Clone the repository and do all the required steps from the Contributing guide
  2. Run this command:
node /path/to/react-native-cli/packages/cli/build/bin.js doctor
  1. Check if Android Studio is installing correctly on Windows when using automatic fix.

Checklist

  • Documentation is up to date to reflect these changes.
  • Follows commit message convention described in CONTRIBUTING.md

@thymikee
Copy link
Member

Mind providing some screenshot to back up it works on Windows? I don't have my machine set up

@szymonrybczak
Copy link
Collaborator Author

@Ashackq mind testing this? 🙏 If you need some help I can help you 🙌

@Ashackq
Copy link

Ashackq commented Sep 11, 2023

@Ashackq mind testing this? 🙏 If you need some help I can help you 🙌
Sure
I've forked the branch and cloned it
what next?

@szymonrybczak
Copy link
Collaborator Author

@Ashackq just follow steps described here.

@Ashackq
Copy link

Ashackq commented Sep 12, 2023

@Ashackq just follow steps described here.

ok everything's set up
how do I test the changes?

@szymonrybczak
Copy link
Collaborator Author

@Ashackq just checkout this branch I use Github CLI for that, and rebuild all packages with yarn and just run yarn doctor and try to run automatic fix.

@Ashackq
Copy link

Ashackq commented Sep 16, 2023

@Ashackq just checkout this branch I use Github CLI for that, and rebuild all packages with yarn and just run yarn doctor and try to run automatic fix.

hey @szymonrybczak
the new android studio version is getting downloaded and working perfectly fine and all the issue are getting fixed with the doctor.🥳

@thymikee thymikee merged commit e0cd7db into main Sep 20, 2023
@thymikee thymikee deleted the feat/upgrade-windows-version branch September 20, 2023 15:09
@thymikee
Copy link
Member

Should we backport this to v11 (RN 0.72)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants