-
Notifications
You must be signed in to change notification settings - Fork 906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: move pods installation from init
to ios-specific commands
#2077
Merged
thymikee
merged 22 commits into
react-native-community:main
from
TMisiukiewicz:refactor/pod-installation
Sep 21, 2023
Merged
perf: move pods installation from init
to ios-specific commands
#2077
thymikee
merged 22 commits into
react-native-community:main
from
TMisiukiewicz:refactor/pod-installation
Sep 21, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thymikee
reviewed
Sep 15, 2023
thymikee
reviewed
Sep 15, 2023
thymikee
reviewed
Sep 15, 2023
thymikee
reviewed
Sep 15, 2023
thymikee
reviewed
Sep 15, 2023
thymikee
reviewed
Sep 15, 2023
TMisiukiewicz
force-pushed
the
refactor/pod-installation
branch
2 times, most recently
from
September 18, 2023 06:35
e4675c1
to
3615491
Compare
thymikee
reviewed
Sep 18, 2023
thymikee
reviewed
Sep 18, 2023
TMisiukiewicz
force-pushed
the
refactor/pod-installation
branch
2 times, most recently
from
September 18, 2023 14:26
0611e23
to
1876e6a
Compare
TMisiukiewicz
force-pushed
the
refactor/pod-installation
branch
4 times, most recently
from
September 19, 2023 09:18
979f872
to
d35c42a
Compare
thymikee
reviewed
Sep 20, 2023
thymikee
reviewed
Sep 20, 2023
thymikee
approved these changes
Sep 20, 2023
adamTrz
approved these changes
Sep 20, 2023
TMisiukiewicz
force-pushed
the
refactor/pod-installation
branch
from
September 21, 2023 07:13
d35c42a
to
5f386b4
Compare
thymikee
changed the title
refactor: move pods installation from
perf: move pods installation from Sep 21, 2023
init
to ios-specific commandsinit
to ios-specific commands
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Currently Pods are installed during
init
command, what makes project setup much longer than it supposed to be. This change makes pods installation optional during theinit
command by displaying the prompt, and moves the installation process to therun-ios
andbuild-ios
commands. Pods are automatically installed when running ios-specific commands and:package.json
--force-pods
was used, which forces to install pods (might be helpful when there are any errors related to pods)Additionally, new flag
--install-pods
was introduced toinit
command, to avoid displaying prompt. If set totrue
, pods will install,false
will skip the installation, and when not used, prompt will be displayed.To install pods during
*-ios
command, it compares md5 hashes of native dependencies names and its versions. To achieve this, I added one new field to dependency config:version
which holds the version of the library from package.json/podspec file.Demo
1.
init
with promptScreen.Recording.2023-09-19.at.10.27.12.mov
2.
init
with--install-pods false
- skip prompt and pods installationScreen.Recording.2023-09-19.at.10.18.10.mov
3.
run-ios
for the first time (cut the video because it takes too long 😄, app runs after installation)run-ios.mov
Test Plan:
y
to confirm - pods should be installed--install-pods
flag - pods should be installed automatically--install-pods false
- prompt & pods installation should be skippedrun-ios
command and verify pods are installed before building the apprun-ios
again and verify app is built without installing pods@react-navigation/native
run-ios
again and verify pods are installed before building the apprun-ios
again and verify app is built without installing podsrun-ios --force-pods
and verify pods are installed before building the appChecklist