refactor(cli-platform-apple): move installing and launching app logic to separate function #2234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thymikee
force-pushed
the
chore/refactor-install-app
branch
from
0a265a5 to
b4043bd
Compare
thymikee
reviewed
Dec 27, 2023
| buildOutput: string, | ||
| scheme: string, | ||
| target: string | undefined, | ||
| buildSettings: any, |
There was a problem hiding this comment.
Shouldn't this be of type BuildSettings from here
thymikee
reviewed
Dec 27, 2023
thymikee
reviewed
Dec 27, 2023
thymikee
reviewed
Dec 27, 2023
thymikee
reviewed
Dec 27, 2023
| } | ||
|
|
||
| type Options = { | ||
| buildOutput: any; |
There was a problem hiding this comment.
Let's add some basic type. According to data flow this can be undefined and I'm not sure if it's handled properly
thymikee
reviewed
Dec 27, 2023
packages/cli-platform-apple/src/commands/runCommand/installApp.ts
Outdated
Show resolved
Hide resolved
szymonrybczak
force-pushed
the
chore/refactor-install-app
branch
2 times, most recently
from
c7efeca to
140c015
Compare
szymonrybczak
commented
Jan 2, 2024
Comment on lines
+54
to
+60
| if (!buildSettings) { | ||
| throw new CLIError('Failed to get build settings for your project'); | ||
| } |
There was a problem hiding this comment.
That's also not the most informative error ever, soon in a separate PR I'll fix all errors in this place :)
cipolleschi
approved these changes
Jan 3, 2024
| buildOutput: string, | ||
| scheme: string, | ||
| target: string | undefined, | ||
| buildSettings: any, |
There was a problem hiding this comment.
Shouldn't this be of type BuildSettings from here
szymonrybczak
force-pushed
the
chore/refactor-install-app
branch
from
140c015 to
99331cc
Compare
szymonrybczak
force-pushed
the
chore/refactor-install-app
branch
from
99331cc to
31e7718
Compare
2 tasks
thymikee
approved these changes
Jan 3, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Moves installing and launching app logic to separate function, so that adding additional logic for another platforms will be fairly easy.
Test Plan:
Works same as before.
Checklist