Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: adapt getSimulators() for OOT platforms #2239

Merged

Conversation

okwasniewski
Copy link
Contributor

@okwasniewski okwasniewski commented Jan 2, 2024

Summary:

This PR removes getSimulators() from createRun and adopts them for createLog. I've also added a handful info message from where we are tailing logs from:

CleanShot 2024-01-03 at 10 58 50@2x

Test Plan:

Check if returned devices are the same.

Checklist

  • Documentation is up to date to reflect these changes.
  • Follows commit message convention described in CONTRIBUTING.md

@okwasniewski okwasniewski marked this pull request as draft January 2, 2024 15:58
@thymikee thymikee requested a review from szymonrybczak January 3, 2024 09:09
@okwasniewski okwasniewski force-pushed the feat/remove-getSimulators branch from 020c91c to 13f520f Compare January 3, 2024 09:58
Copy link
Contributor

@cipolleschi cipolleschi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like that the code is much simpler now!

@okwasniewski okwasniewski marked this pull request as ready for review January 3, 2024 10:00
@okwasniewski
Copy link
Contributor Author

As pointed out by @szymonrybczak (in private message) we can't remove getSimulators() for createLog as it contains the necessary info stated in the comment:

// Here we're using two command because first command xcrun simctl list --json devices outputs state but doesn't return available. But second command xcrun xcdevice list outputs available but doesn't output state. So we need to connect outputs of both commands.

@okwasniewski okwasniewski changed the title refactor: remove getSimulators() refactor: adapt getSimulators() for OOT platforms Jan 3, 2024
@thymikee thymikee merged commit c70db3d into react-native-community:main Jan 3, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants