fix: allow users to specify --device
without value
#2263
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Fixes #2262.
In #2078
--device
was accidentally removed, and in #2086 the flag was restored, but with a small change where now--device
flag accept value wrapped<>
instead of[]
:cli/packages/cli-platform-apple/src/commands/runCommand/runOptions.ts
Line 46 in f50cc16
cli/packages/cli-platform-ios/src/commands/buildIOS/index.ts
Line 227 in a2eb8c0
that caused a regression, because with
<>
value is required, but with[]
is optional.Test Plan:
Checklist