Put an upper bound on "**/Podfile" search depth #2480
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR addresses #2479. Basically the unbounded search for
**/Podfile
never finishes on my machine. Normally the required depth should be2
, sinceios/Podfile
is the default location. So this still provides significantly more depth than most users should need.Test Plan:
To be honest I'm not sure what causes this issue on my system, I only investigated what fixes it so far. It's clearly an issue with a deeply-nested submodule that we have, but I can't see what about it is causing the issue. If I run
find .
in my project root, all files (including the deeply-nested ones) can be printed within a few seconds, whereasfast-glob
appears to never finish its search without thisdeep: 10
limitation.Checklist