RFC: Removing the "Perf" and "Network" tabs from the in-app Element Inspector #777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huntie
changed the title
huntie
force-pushed
the
proposal-remove-legacy-element-inspector-features
branch
from
582e1f5 to
14f961a
Compare
|
Yes please! |
cortinico
approved these changes
Apr 5, 2024
|
this seems like a pragmatic decision to me. I doubt many people actually use these features, indeed I had forgotten these buttons even existed. there are better ways of getting both types of information. |
elicwhite
approved these changes
Apr 6, 2024
|
What is a better way to get the info for the perf tab? I use this all the time! |
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Sep 3, 2024
Summary: Changelog: [General][Breaking] - Remove Inspector Panel perf + network tabs under New Arch (see react-native-community/discussions-and-proposals#777) Differential Revision: D62123634
facebook-github-bot
pushed a commit
to facebook/react-native
that referenced
this pull request
Sep 9, 2024
Summary: Pull Request resolved: #46307 Changelog: [General][Breaking] - Remove Inspector Panel perf + network tabs under New Arch (see react-native-community/discussions-and-proposals#777) Reviewed By: christophpurrer Differential Revision: D62123634 fbshipit-source-id: 44ecc476943ccb33f8de96dcefa3e233e954841a
|
I haven't even clicked once on these tabs since the beginning. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identifies two sub-features of the in-app Element Inspector which we believe are not worth reimplementing under the New Architecture.
View the rendered RFC