Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add detox #155

Merged
merged 8 commits into from
May 21, 2020
Merged

add detox #155

merged 8 commits into from
May 21, 2020

Conversation

vonovak
Copy link
Member

@vonovak vonovak commented Apr 27, 2020 •
edited
Loading

Summary

this adds e2e tests for android and ios using detox, running in CircleCI, including video recordings and logs! 🎉

Test Plan

tests pass 😄

Compatibility

OS Implemented
iOS ✅
Android ✅

Checklist

  • I have tested this on a device and a simulator
  • I added the documentation in README.md
  • I mentioned this change in CHANGELOG.md
  • I updated the typed files (TS and Flow)
  • I added a sample use of the API in the example project (example/App.js)

@vonovak vonovak force-pushed the @vonovak/detox branch 15 times, most recently from 3188917 to 659505c Compare April 29, 2020 13:10
This was referenced May 7, 2020
Merged
Merged
Closed
Merged
vonovak added 4 commits May 17, 2020 18:55
@vonovak
add detox
9601bd7 
try android

again

use circus, not headless

use hermes with e2e

test hermes is used

verbose

add missing await

use android 28
@vonovak
use latest deps
bdb3307
@vonovak
use latest orb
795b4ec
@vonovak
test fix to orb
37a7a0b
@vonovak vonovak force-pushed the @vonovak/detox branch 2 times, most recently from 61cfbfb to 6858ecc Compare May 17, 2020 18:47
@vonovak vonovak requested a review from luancurti May 20, 2020 17:38
@vonovak vonovak marked this pull request as ready for review May 20, 2020 17:38
luancurti
luancurti approved these changes May 21, 2020
View reviewed changes
Copy link
Member

@luancurti luancurti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great Job! 🎉

@luancurti luancurti merged commit 4580d06 into master May 21, 2020
@vonovak vonovak deleted the @vonovak/detox branch May 21, 2020 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luancurti luancurti luancurti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vonovak @luancurti