Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix allFiles on iOS #352

Closed
wants to merge 1 commit into from
Closed

Fix allFiles on iOS #352

wants to merge 1 commit into from

Conversation

matei-oltean
Copy link
Contributor

As said in #342, the wrong type is used for allFiles. .zip files (and many others) cannot be used.
According to https://developer.apple.com/documentation/uniformtypeidentifiers/uttypecontent, public.content must also conform to public.data or com.apple.package.

@vonovak
Copy link
Collaborator

vonovak commented Oct 28, 2020

hello, thanks for opening the PR!
Why not just use public.item as said in #342?

it seems it's the base type of both public.data and com.apple.package

Thanks!

@matei-oltean
Copy link
Contributor Author

Indeed... I unfortunately deleted my branch by mistake so I am staring a new PR instead; sorry :|
#356

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matei-oltean @vonovak