-
-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: rework module using react native bob #421
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I confirm everything keeps working fine on Windows. In the next days I will work on a Windows sample to add to the existing ones and I'll submit a PR.
9e9ef9e
to
4d46013
Compare
@qmatteoq perfect, thank you! There's one more thing: this PR #380 added a folder picker windows-only functionality to the library but was never documented. In a recent PR, the same functionality was added on Android #414, under the Would you be so kind and rework the old, undocumented implementation so that Also, what do you think of the naming? Would you prefer this to be named btw I'll be vacationing now for 10 days so I won't respond here :) |
The way I implemented this feature in Windows is to retrieve a list of all the files in the selected folder, but I realize that this is different from what you have in the other platforms. I will rework the feature to work like on Android and return the path of the selected folder and submit a PR. Enjoy your holidays! 😊 |
I like |
Added Windows implementation of the sample
* feat: added pickDirectory implementation for Windows * fix: fixed typo in property name
so, the PR is now complete. I will find some time later this week to merge this and set up automated publishing. |
BREAKING - this commit will publish work done in #421 * chore: set up automated releases
BREAKING CHANGE: includes the work from (#421)
BREAKING CHANGE: includes the work from (#421)
Summary
this PR reworks the module to be built on top of react native builder bob which provides some cool benefits out of the box:
closes #343
Test Plan
Example project runs on android and ios device
should run on windows as well: @qmatteoq could you please double check this works fine on windows and add example project that could be used for development? Perhaps datetime picker repo could be of help: https://github.com/react-native-datetimepicker/datetimepicker/tree/master/example
What are the steps to reproduce (after prerequisites)?
see contributing.md
Compatibility
Checklist
README.md