Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add instructions for usage in an Expo project #556

Merged
merged 2 commits into from
Apr 30, 2022

Conversation

fobos531
Copy link
Contributor

@fobos531 fobos531 commented Apr 19, 2022

Summary

Adding on to this issue, I wondered why it was claimed that this package is not supported in an Expo project. Mainly due to the fact that the package doesn't require modification of any specific native project files so config plugins are not required. I went ahead to verify this by initializing an Expo project, adding this package and creating a development build of the app, and lo and behold, the package worked flawlessly. So, I would say, the only way this package is unsupported in Expo is by the fact that it doesn't have Expo installation instructions yet. This is what this PR does :)

Test Plan

N/A

What's required for testing (prerequisites)?

  • expo project
  • apple developer account for testing on a physical iOS device

What are the steps to reproduce (after prerequisites)?

  • add this package by following the installation instructions provided in this PR
  • use the package as usual.

Compatibility

OS Implemented
iOS
Android

Checklist

  • I have tested this on a device and a simulator
  • I added the documentation in README.md
  • I updated the typed files (TS and Flow)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants