Feat/new arch #588
Closed
Feat/new arch #588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vonovak
force-pushed
the
feat/new-arch
branch
from
ffa3961 to
7a48e5d
Compare
vonovak
force-pushed
the
feat/new-arch
branch
from
7a48e5d to
f7aa05c
Compare
vonovak
force-pushed
the
feat/new-arch
branch
from
f7aa05c to
427e9e7
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
clone this PR
run
npx react-native run-android --active-arch-onlyand you'll probably be met with 2 errors which can be fixed as follows:to also look for
"../../package.json"packages/react-native-codegen/libfrom react-native repo to the<document-picker>/node_modules/react-native-codegen/libthen, when I rebuild, I get more complicated errors: https://gist.github.com/vonovak/7dcef431731a5e175a84f1767ba6ccfe
Would appreciate pointers to move forward 🙂
edit: I have this pretty much done locally but need one more push to bring it over the line 👍