Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update scripts in contributing.md #594

Conversation

jblarriviere
Copy link
Contributor

Summary

The commands for testing the example app, given in contributing guidelines, were outdated

Test Plan

What's required for testing (prerequisites)?

NA

What are the steps to reproduce (after prerequisites)?

NA

Compatibility

OS Implemented
iOS ✅❌
Android ✅❌

Checklist

  • I have tested this on a device and a simulator
  • I added the documentation in README.md
  • I updated the typed files (TS and Flow)

@vonovak vonovak merged commit 78bc0de into react-native-documents:master Oct 13, 2022
@vonovak
Copy link
Collaborator

vonovak commented Oct 13, 2022

thanks for the PR! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants