Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix return notification fireDate #89

Merged
merged 2 commits into from
May 24, 2020

Conversation

narender2031
Copy link
Contributor

@narender2031 narender2031 commented Mar 19, 2020

Summary

We need to have a fireDate in the response of the notification. It is impossible to figure out what date or time it was triggered without fireDate

Test Plan

What's required for testing (prerequisites)?

What are the steps to reproduce (after prerequisites)?

Compatibility

OS Implemented
iOS
Android

js/index.js Outdated Show resolved Hide resolved
Copy link
Collaborator

@Naturalclar Naturalclar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Naturalclar Naturalclar changed the base branch from master to next May 24, 2020 04:44
@Naturalclar Naturalclar merged commit 0dd51f1 into react-native-push-notification:next May 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants