This repository has been archived by the owner on Sep 22, 2022. It is now read-only.
fix: allow different shops to have same tag name #30
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Mohan Narayana [email protected]
Resolves #28
Impact: minor
Type: bugfix
Issue
The problem is that Tag's slug is unique across the whole system. For system where there can be multiple shops it doesn't look like a good solution since it's a very common case to have same tags in different shops
Solution
Make slug and shopId index pair value to be unique.
Testing
{ namespace: "tags", package: "@reactioncommerce/api-plugin-tags", version: 2 }
MONGO_URL=mongodb://localhost:27017/reaction npx migrator migrate