This repository has been archived by the owner on May 5, 2020. It is now read-only.
Fix for example plugin #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oken due to refactoring. Things changed: a) The navigation bar is now a React component b) The default route permissions are no longer maintained in Shop collection, but a dedicated Group collection This closes the error reported here: https://forums.reactioncommerce.com/t/reaction-example-plugin-not-working/623
Changes: 1) Replace footer and header templates with React components that are sourced dynamically from registry's layout definitions. 2) Static page 'AboutUs' is now a React component 3) Fix for static page /about which pulled in wrong layout because of non-matching workflow value in register.js Note: This change depends on register.js changes in core to work propertly. Also it requires to be the core's footer React component to be existent and registered as `Footer`.
Blaze template instead of new React component CartSubTotal.
|
@zenweasel I actually would retain the blue 'Debug bar' as it gives the developer a hint, what's going on under the hood. |
|
I'm getting a following error from this branch: Footer.js in the trace is the footer.js from this plugin. I just did reaction init (with latest version of npm tool), and cloned this branch into imports/plugins/custom. Am I doing something wrongly? |
|
@piizei This PR depends on another PR (reactioncommerce/reaction#3257) in core, which isn't approved yet. |
brent-hoover
approved these changes
Nov 21, 2017
brent-hoover
deleted the
michael-fix-issue-example-plugin-not-working
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The example plugin had different bugs which were fixed:
Refactored: