Rename variables and functions (#2690)

reactioncommerce · Sep 12, 2017 · 1eca226 · 1eca226
1 parent 055a46d
commit 1eca226
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 10 deletions.
diff --git a/imports/plugins/included/product-variant/components/gridItemControls.js b/imports/plugins/included/product-variant/components/gridItemControls.js
@@ -7,7 +7,7 @@ class GridItemControls extends Component {
     checked: PropTypes.func,
     hasChanges: PropTypes.func,
     hasCreateProductPermission: PropTypes.func,
-    inValidVariant: PropTypes.array,
+    invalidVariant: PropTypes.array,
     product: PropTypes.object
   }
 
@@ -22,7 +22,7 @@ class GridItemControls extends Component {
   }
 
   renderVisibilityButton() {
-    if (this.props.inValidVariant.length) {
+    if (this.props.invalidVariant.length) {
       return (
         <div>
           <Components.IconButton

diff --git a/imports/plugins/included/product-variant/containers/gridItemControlsContainer.js b/imports/plugins/included/product-variant/containers/gridItemControlsContainer.js
@@ -24,7 +24,7 @@ const wrapComponent = (Comp) => (
       this.validation = new Validation(ProductVariant);
 
       this.state = {
-        inValidVariant: []
+        invalidVariant: []
       };
 
       this.hasCreateProductPermission = this.hasCreateProductPermission.bind(this);
@@ -33,7 +33,7 @@ const wrapComponent = (Comp) => (
     }
 
     componentWillMount() {
-      this.checkLabelValidation();
+      this.variantValidation();
     }
 
     hasCreateProductPermission = () => {
@@ -48,20 +48,20 @@ const wrapComponent = (Comp) => (
       return this.props.isSelected === true;
     }
 
-    // checks whether the product variant has a Label
-    checkLabelValidation = () => {
+    // checks whether the product variant id valid
+    variantValidation = () => {
       const variants = ReactionProduct.getVariants(this.props.product._id);
       let validationStatus;
-      let inValidVariant;
+      let invalidVariant;
       if (variants) {
         validationStatus = variants.map((variant) => {
           return this.validation.validate(variant);
         });
 
-        inValidVariant = validationStatus.filter(status => status.isValid === false);
+        invalidVariant = validationStatus.filter(status => status.isValid === false);
       }
       this.setState({
-        inValidVariant
+        invalidVariant
       });
     }
 
@@ -72,7 +72,7 @@ const wrapComponent = (Comp) => (
           hasCreateProductPermission={this.hasCreateProductPermission}
           hasChanges={this.hasChanges}
           checked={this.checked}
-          inValidVariant={this.state.inValidVariant}
+          invalidVariant={this.state.invalidVariant}
         />
       );
     }