Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tiered/Group Pricing + Media #1715

Closed
dguedry opened this issue Jan 15, 2017 · 5 comments
Closed

Tiered/Group Pricing + Media #1715

dguedry opened this issue Jan 15, 2017 · 5 comments

Comments

@dguedry
Copy link

dguedry commented Jan 15, 2017

Working on a Magento import plugin (https://github.com/dguedry/reaction-magento-import). Are there any plans to implement tiered/group pricing? We use this in our Magento stores for retail vs wholesale.

I'd like to go ahead and start developing a "Group Price" plugin if it's not already slated.

Thanks!

Donnie

@aaronjudd
Copy link
Contributor

aaronjudd commented Jan 17, 2017

In Reaction, variants, options, etc are all product documents, and all your images can be associated at any level, (so at the product) and as many as you want. The association is in the image meta data, and right now the default view is just the first image is determined by the priority value in the meta data. If you do associate to both products and variants, you'll need the ancestor array from the variants so that can retrieve all associated images from the Media collection. ( by default, we'll cascade down this ancestry when presenting a product, so we don't have products with no images when a variant does have images).

@aaronjudd aaronjudd self-assigned this Jan 17, 2017
@aaronjudd
Copy link
Contributor

Regarding pricing, this can be done via the "Discounts" collection (which is likely to be renamed "Pricing" in the future, because that's the true intent). We'll be adding conditionals soon, but what I think you are looking for is to return a price/rate as a conditional audience result, and that's what we're implementing there..

@dguedry
Copy link
Author

dguedry commented Jan 19, 2017

The product grid picks the correct image if the image's metadata only contains productId (and variantId == null); however, the productImageGallery.js helper for media selects by variantId only. So, if the product's variantId is not set, all images that have a variantId of null are returned to the product page (even though they don't have the correct productdId).

@kieckhafer
Copy link
Member

kieckhafer commented Jan 20, 2017

I'm working through an issue (#1303) right now that seems to have a tie-in to this discussion. On the product grid, we seem to only subscribe to and / or only publish top-level products (type: simple), no variants (type: variant), meaning we can't use our getVariants method, or any other we already have for that matter, as this needs the variants subscribed to in order to check match them to their ancestors.

I'm currently working to add the Variants info into the grid page data, so ancestor info will be available, by subscribing to all the data in the products collection, not just top-level products.

Not only will this help with what we are trying to achieve in #1303 and #1715, but it will also set us up for the future when we want to display Product Variants and Options together with the top-level product on the grid page.

Update: PR #1738 updates the product publication to publish type: variant data as well as the type: simple product data.

@aaronjudd aaronjudd added ready and removed backlog labels Apr 25, 2017
@aaronjudd aaronjudd added this to the Marketplace Media milestone Apr 25, 2017
@aaronjudd aaronjudd removed their assignment Aug 14, 2017
@aaronjudd
Copy link
Contributor

Feature request that requires more definition to meet our current issue guidelines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants