-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Avalara] Allow addresses that don't validate #2104
Comments
So Avalara may still throw an error if City/State/Zip don't validate when we do the "Estimate Cart" call (which will happen after a shipping method is applied(). So we need to handle that error if throw and push the customer back to the address workflow. |
I have it allowing the user to pass through validation after receiving the first set of corrections/warnings. And it's throwing the user back to the Also debating on whether I want to dig myself a deeper hole by trying to build out a better UI for address validation. I already built code to parse out the data given to me by Avalara into meaningful messages but not currently using it. Not to mention this needs to get converted to React and currently it's just basically a single line of Autoform. So you know, 😢 |
@rymorgan Could you take a look at this and give me your thoughts? The thing that concerns me is that for customers that have Avalara enabled this will come up quite a bit because your address only has to differ in spelling or punctuation and it's going to kick it back. I think this works but maybe there is a better way. I've cleaned up the styling a little bit, but the flow is still basically the same as the above. |
pinging @rymorgan again. If you could just take a second I would appreciate it. |
My thinking is we add a notification at the top letting them know what is going on (aka fields should be validated.)
|
@zenweasel Is this done? I'd love to see the execution. |
Closed via #2162 |
Customers should be warned but not blocked from entering addresses that don't completely validate.
Waiting for clarification on whether this means City/State/Zip don't validate or entire address.
The text was updated successfully, but these errors were encountered: