Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address review workflow #2162

Merged
merged 31 commits into from
Jun 8, 2017
Merged

Address review workflow #2162

merged 31 commits into from
Jun 8, 2017

Conversation

brent-hoover
Copy link
Collaborator

@brent-hoover brent-hoover commented Apr 25, 2017

Closes #2104

Adds a new step for when address validation returns a different address. Allows them to "merge" the validated address with their entered address.

How to Test

  1. Enable Avalara
  2. Add something to cart and checkout
  3. Add an address that doesn't validate (which will be pretty much any address)
  4. Observe that you can reconcile the address using this new screen

@brent-hoover brent-hoover changed the title [WIP] Address review workflow Address review workflow May 25, 2017
@brent-hoover brent-hoover requested a review from kieckhafer May 25, 2017 06:25
@brent-hoover brent-hoover changed the title Address review workflow [WIP] Address review workflow May 27, 2017
@brent-hoover brent-hoover changed the title [WIP] Address review workflow Address review workflow Jun 5, 2017
Copy link
Member

@kieckhafer kieckhafer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validation works.

We are going to adjust the design a bit, but I'll make a new ticket / PR for @rymorgan and myself to look over.

@kieckhafer kieckhafer merged commit d202a0a into development Jun 8, 2017
@kieckhafer kieckhafer deleted the brent-fix-issue-2104 branch June 8, 2017 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants