Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix validation on PDP #2274

Closed
brent-hoover opened this issue May 16, 2017 · 11 comments
Closed

Fix validation on PDP #2274

brent-hoover opened this issue May 16, 2017 · 11 comments
Assignees
Labels
bug For issues that describe a defect or regression in the released software

Comments

@brent-hoover
Copy link
Collaborator

All fields that are required or have a set type need to provide some user feedback.

@brent-hoover
Copy link
Collaborator Author

This should be part of the style guide, but for now we need a way to consistent display errors that require action.

@brent-hoover
Copy link
Collaborator Author

Right now everything is just being thrown up in a toast. This is actually a regression for some of these fields like price and dimension where we would see the field highlighted, etc.
dumb_product

@brent-hoover
Copy link
Collaborator Author

I should be able to enter $0.00 as a valid price on a product. Sometimes things are free. Right now I get a "Price is required" toast.

@aaronjudd aaronjudd added bug For issues that describe a defect or regression in the released software critical impact labels Jun 20, 2017
@brent-hoover brent-hoover changed the title Revisit validation on PDP Fix validation on PDP Jun 20, 2017
@brent-hoover
Copy link
Collaborator Author

We don't need to wait for design here, I think we all know the basics of how validation should work. The field should be focused, the error should show next to the field, etc.

@rymorgan
Copy link
Contributor

@zenweasel totally agree. If you guys take a stab at it and send it my way when it's done. But yes it should just as you describe.

@brent-hoover
Copy link
Collaborator Author

I just talked to @kieckhafer and he is willing to take this on. Hopefully we can expand the Autoform replacement work that @mikemurray has been working on

@rymorgan
Copy link
Contributor

@kieckhafer let me know when you work on this and we can talk through how the validation should be styled. I'm hoping this is something that does some automatic validation magic with our forms so we're consistent everywhere.

@aaronjudd
Copy link
Contributor

Removed "critical impact" with the merge of #2531

@mikemurray
Copy link
Member

This PR (#2893) should be able to close this issue once it's merged

@mikemurray
Copy link
Member

Also assigned @kieckhafer since he's fixing this in his PR #2893

@kieckhafer
Copy link
Member

Closed by #2893

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug For issues that describe a defect or regression in the released software
Projects
None yet
Development

No branches or pull requests

5 participants