Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error flag on every admin component #2691

Closed
janat08 opened this issue Aug 16, 2017 · 4 comments
Closed

Error flag on every admin component #2691

janat08 opened this issue Aug 16, 2017 · 4 comments

Comments

@janat08
Copy link

janat08 commented Aug 16, 2017

Expected behavior

There's no highlighting of errors for admin.

Actual Behavior

product without title/sub/label being blocked from publish, yet is saved as draft. #2690

Steps to Reproduce the Behavior

spam create products, and go to shop front to publish all where things will get funny.

Versions

Node: 6.11.2
NPM: 3.10.10
Meteor Node: 4.8.4
Meteor NPM: 4.6.1
Reaction CLI: 0.11.0
Reaction: 1.4.1
Reaction branch: master

Changes

Flag a component as errored (or rather obj prop), on publish all walk through product object in minimongo that will single out product draft to let show those products, and then component responsible with highlighted CSS. If details become filterable than it will be helpful if there's schema in place (default detail fields) or what-not.

@brent-hoover
Copy link
Collaborator

@janat08 This ticket is really hard to understand. Could you please provide more detail such as proper steps to reproduce, and where this ticket differs from the already existing tickets such as #2274?

In order to work on these tickets and understand them in the context of other issues we have, we really need all sections of the issue template filled out completely. The more complete and clear these are, the more likely we will be able to fix the bug/problem.

@janat08
Copy link
Author

janat08 commented Aug 22, 2017

If you don't try and publish after every item creation, instead creating them continuously this error checking with toast will require you to then go through every single item, instead of highlighting items that prevent publish all.

@janat08
Copy link
Author

janat08 commented Aug 22, 2017

#2690 is an issue description. I suppose this is issue for recommending against blocking publish all button (cursor turns into stop sign), since you'd want to use it for determining what is broken.

@brent-hoover
Copy link
Collaborator

Ok, then maybe you can put your comments there on #2274 rather than creating another issue. Having duplicate/overlapping issues creates a lot of overhead for us.

This is a legitimate problem, I am just trying to keep out system clear so it makes it easy for us to fix things and know when they are fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants