Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReactTable UI display issues #2557

Closed
aaronjudd opened this issue Jul 14, 2017 · 4 comments
Closed

ReactTable UI display issues #2557

aaronjudd opened this issue Jul 14, 2017 · 4 comments
Labels
bug For issues that describe a defect or regression in the released software

Comments

@aaronjudd
Copy link
Contributor

UI issues displaying empty tables.

reaction

reaction_and_1__rc__node__and_reactioncommerce_reaction

Node: 7.5.0
NPM: 5.0.0
Meteor Node: 4.8.4
Meteor NPM: 4.6.1
Reaction CLI: 0.10.2
Reaction: 1.3.1
Reaction branch: release-1.3.1
Docker: 17.03.1-ce
@aaronjudd aaronjudd added bug For issues that describe a defect or regression in the released software UIX labels Jul 14, 2017
@kieckhafer
Copy link
Member

The No Results UI is the default that comes with React-Table, we can definitely update it to look a little different, but I don't know if that's technically a bug so much an enhancement.

@rymorgan We briefly discussed this, but decided to stay with this just to get it pulled in. Any thoughts since then?

The page dropdown on the second line probably shouldn't be happening.

@aaronjudd
Copy link
Contributor Author

aaronjudd commented Jul 17, 2017

I think that this UI looks broken, and it's not an enhancement, but falls under UI QA, and is a bug... we should clean this up. (do we just need to make a custom "theme")?

@rymorgan
Copy link
Contributor

@aaronjudd Worked with @kieckhafer on this yesterday. Here's the PR to check it out. We are aware there is an issue with the next button when pagination kicks in. @kieckhafer Is creating another issue for that.

#2597

@kieckhafer
Copy link
Member

Closed via #2597

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug For issues that describe a defect or regression in the released software
Projects
None yet
Development

No branches or pull requests

3 participants