UI Updates for SortableTable #2597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rymorgan
approved these changes
Jul 26, 2017
aaronjudd
approved these changes
Jul 31, 2017
There was a problem hiding this comment.
Approved, the UI changes are good. I'm noting that i18n is not loading the Sortable table labels the first time a site loads though (generally an issue right now in marketplace), and also that test fail with 1) Merge Cart function should increase product quantity if anonymous cart items exists in user's cart before merge -> also an issue in marketplace right now (and since this is merging into that.. I think we're good here).
Merged
|
Fixed #2557 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2557
Pagination on smaller actionView now on one line:
Pagination hidden, search hidden, and better "No Data" overlay when no results:
