Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't unselect tag in product detail #48

Closed
bstocks opened this issue Apr 23, 2014 · 3 comments
Closed

Can't unselect tag in product detail #48

bstocks opened this issue Apr 23, 2014 · 3 comments

Comments

@bstocks
Copy link
Contributor

bstocks commented Apr 23, 2014

When tag is selected as the hashtag in product detail it can't then be unselected. It seems that it should either be required to make the product live, or allow for unselection.

silicon beach tee

@aaronjudd
Copy link
Contributor

You have to select another tag. Once you select a tag, you must select another to change. You think you should be able to have no tags selected (allowing product to use the autogenerated id)?

@bstocks
Copy link
Contributor Author

bstocks commented Apr 25, 2014

Yes and my reasoning is that as the user it was an uncomfortable interaction to be exploring tags, see the little bookmark flags and click one just to try it and then have no option to undo. If you want users to make a selection rather than use the autogenerated id, then it seems like it should be enforced as a required field before product creation is complete.

@aaronjudd
Copy link
Contributor

Note: that if a user is viewing a product that you remove the active bookmark/hashtag then they'll immediately get access denied. Same would happen if you deleted it. Need to look at ways to redirect all active viewers to the new product url.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants