Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Product page title cut off #86

Closed
bstocks opened this issue Jun 3, 2014 · 6 comments
Closed

Product page title cut off #86

bstocks opened this issue Jun 3, 2014 · 6 comments

Comments

@bstocks
Copy link
Contributor

bstocks commented Jun 3, 2014

When logged in as Admin, the product page title field needs either some kind of clear truncation or to display the full text no matter how many characters.

guard shack

It displays fine for the end user, but the admin doesn't see it the same way. I vote for displaying it the same for both rather than truncating.

@aaronjudd
Copy link
Contributor

Note, input is now responsive - so it's going to depend on the screen size.

@bstocks
Copy link
Contributor Author

bstocks commented Jun 25, 2014

The responsiveness is an improvement, but for longer strings the admin view is still not aligned with the shopper view.

Shoppers get to see the full text no matter how long because it wraps to multiple lines. In the admin view it eventually gets cut off, even on larger screens. Is is possible to have the admin input become two lines when the string is too long to fit on one?

@bstocks bstocks reopened this Jun 25, 2014
@aaronjudd
Copy link
Contributor

it's really not meant to be that long. it's not a description field. input field would have to be a text area to wrap, I don't think that's the correct use for this field if it's longer wider than a large page.

@bstocks
Copy link
Contributor Author

bstocks commented Jun 25, 2014

Ok, I get that.

What about people editing products from a netbook or tablet? Even shorter strings (10-15 words) get cut off on those screen sizes. I know this isn't high priority, but it still seems like a place that we could eventually get more alignment between admin with user views.

@aaronjudd
Copy link
Contributor

really that field is meant to be five words or so.

@aaronjudd
Copy link
Contributor

it's a headline. like "Save Big". "Only 50 in stock". " Handmade by craft Artisans", etc

aaronjudd pushed a commit that referenced this issue Dec 3, 2015
cmbirk pushed a commit to cmbirk/reaction that referenced this issue Aug 18, 2019
…ellon-loyalty-plugin-with-rewards

chore: enable Graphiql in INT
brent-hoover pushed a commit that referenced this issue Sep 20, 2022
…glob-parent-5.1.2

chore(deps): Bump glob-parent from 5.1.1 to 5.1.2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants