Function isSoldOut() should return true if quantity is <= 0 #1311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ly if it is === 0.
|
👍 |
|
👍 looks good |
jshimko
added a commit
that referenced
this pull request
Aug 23, 2016
* development: (27 commits) Release 0.15.1 (#1314) Fix wrong method hooks context (#1307) - function isSoldOut() should return true if quantity is <= 0, not only if it is === 0. (#1311) Remove jquery-ui (#1310) Taxes (#1289) Fix Stripe refunds and Double Discounts (#1304) fix refunds and discounts for authorize.net (#1279) Fix Braintree discounts and refunds (#1265) Allow any user who has the createProduct permission to also delete products (#1263) Remove bash script from postinstall to fix Windows installs (#1299) update cardNumber schemas Fix PayPal PayFlow discounts and refunds (#1275) logout and hasPermission updates (#1290) Create email job queue and Reaction.Email namespace (#1282) updated package.json (#1286) Update circle node (#1281) Use forked version of authorize.net that doesn't have vulnerability (#1252) fix for #1072 (#1247) Temporarily bypass failiing inventory test (#1280) Fix inventory tests (#1254) ... # Conflicts: # .codeclimate.yml # .eslintignore # .meteor/versions # client/modules/core/main.js # imports/plugins/core/orders/client/templates/workflow/shippingTracking.js # imports/plugins/core/taxes/client/settings/custom.js # imports/plugins/core/taxes/client/settings/settings.js # imports/plugins/core/taxes/server/methods/methods.js # imports/plugins/included/authnet/server/methods/authnet.js # imports/plugins/included/braintree/server/methods/braintreeApi.js # imports/plugins/included/braintree/server/methods/braintreeMethods.js # imports/plugins/included/braintree/server/methods/braintreeapi-methods-refund.app-test.js # imports/plugins/included/example-paymentmethod/server/methods/example-payment-methods.app-test.js # imports/plugins/included/inventory/server/hooks/hooks.js # imports/plugins/included/inventory/server/hooks/inventory-hooks.app-test.js # imports/plugins/included/inventory/server/methods/inventory.js # imports/plugins/included/inventory/server/methods/statusChanges.js # imports/plugins/included/launchdock-connect/client/templates/dashboard.js # imports/plugins/included/paypal/server/methods/payflowpro-methods-refund.app-test.js # imports/plugins/included/paypal/server/methods/payflowproApi.js # imports/plugins/included/paypal/server/methods/payflowproMethods.js # imports/plugins/included/product-variant/client/templates/products/productDetail/variants/variantForm/variantForm.js # imports/plugins/included/taxes-avalara/server/hooks/hooks.js # imports/plugins/included/taxes-taxcloud/server/hooks/hooks.js # imports/plugins/included/taxes-taxjar/server/hooks/hooks.js # lib/collections/helpers.js # package.json # server/api/core/import.js # server/methods/catalog.js # server/methods/core/cart-remove.app-test.js # server/methods/core/orders.js # server/methods/core/shop.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not only if it is === 0.