Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1586 cart product link doesnt work - fix #1861

Merged
merged 292 commits into from
Feb 21, 2017

Conversation

prosf
Copy link
Collaborator

@prosf prosf commented Feb 17, 2017

fixes #1586

CartDrawerItems template isn't using Product Collection anymore to get product's URL.
Instead, gets all the information from the Cart's item.

code by Aaron

brent-hoover and others added 30 commits November 14, 2016 07:58
* change templates importing to use Assets collection

* renamed templates function

* fixed listing errors

* add flush & changed onCoreInit -> afterCoreInit

* removed isOriginalTemplate, which is no longer used

* InitTemplates() -> initTemplates()
- moved “Import” from settings/settings.html to import/import.html
- is currently not used and won’t be visible, but can be basis for
import settings.

resolves #1050
* update workflow when process is not done the traditional way

* update import order

* fixed linting issues

* removed old / unused nom packages
* Added add button for variant list.

Hide available options divider, if there are no available options.

* UX tweaks for varying numbers of variants in list

- Hide options label when there is only one top level variant
- add tooltip to add button

* Hide add button for non-admin users

* More UI tweaks for products without variants

Hide add to cart button if there are no variant options available.
Hide options separator if there are no variant options and use is not
an admin.

* Added i18n
* fix for templates not loading on initial reaction startup

* changed the order

* move i18n to new modular style

* formatting

* Update core.js

* Update core.js

* Update index.js

* Update email.html

* removed "moo"
* Add media hook. Rename file to "hooks'"

* Only return published images for non-admin users

* Only set product images as unpublished

* Capture revision record and show Publish button when image changes are made

* Adding images deferred until published

* Removing images deferred until published

* Capturing and deferring other changes to metadata (priority really)

* Combine revisions when making multiple changes before publishing

* Properly handle non-product revisions in applyProductRevision so that product doesn't get wiped.

* Find the product correctly based on revision type

* Fix regression where images weren't being published because revision data was wrong

* Setting priceRange should be in an `else` statement

* If you add an image and then delete it before publishing it, just remove it.

* Update revisions with media

* Show visual indicator on image if there are pending revisions

* Discard drafts of image revisions

* Sometimes rendering the "edited" marker

* Reset revisions so that removals take effect

* Set priority to revision priority

* Fix issue where changing order wouldn't stick

* Remove logging

* Change lost in merge

* Another change from merge

* Don't show remove icon once an item has been removed.

* Protect against a non-existent product
Allow for disabling/overriding of search modal from a plugin
 country-data          ^0.0.30  →     ^0.0.31
 griddle-react          ^0.6.1  →      ^0.7.0
 i18next                ^3.4.3  →      ^4.0.0
 sortablejs             ^1.4.2  →  ^1.5.0-rc1
 sweetalert2            ^5.3.8  →      ^6.1.0
 wdio-mocha-framework   ^0.4.3  →      ^0.5.4
kieckhafer and others added 18 commits February 14, 2017 09:41
* LESS updates for PDP media gallery

* split into featured media and thumbnails

* pass props down to mediaGallery

* always return featured media as true

* always allow featuredMediaOnHover

* add react-measure

* update less

* add react-measure

* pull image measurements from mediaGallery

* fix sizing issue on admin featuredImage

* fix error when removing unpublished media

* add key to Measure to fix error
* Prevent product deletion from creating revisions for archived products

Prevent instances where archiving a product would also archive products
that are already archived, resulting in more revision documents being
created when not necessary.

* Prevent variant deletion from creating revisions for archived products

* Prevent broken ancestors during archived product restoration

- Prevent a child variant from being restored if its parent variant is
still marked as `isDeleted` (archived).

* - Import Tags collection to fix errors on product create

* Prevent child variants from being added to a deleted parent variant

* Add default label for variant so it doesn't look broken when new.

* Update error messaging for add top variant

* Don't allow a product to be cloned if its parent is deleted

* Updated translations and comments

* Adjust import order

* Shorten i18n text

* Fix alert display when archiving products
* Added ability to publish all items on product grid

When no items are selected on the product grid, the publish controls in
the toolbar defaults to publishing all changes to all products on the
grid.

* Update product grid display

- Add overlay to products when they are not visible
- Add indicator when products have changes
- Sort product grid after revision data is applied

* Removed sort and limit from product find

* Simplify product positions update.

Simplify update for product positions to prevent cases where updating
the size and then position will cause products to be rendered in
incorrect positions or sizes.
* Remove deprecated avalara package

* Replace npm package

* Add new fields

* Use new internal module

* Implement new TaxRate API

* Get and save company code

* Submittting cart to Avalara (not working yet)

* Adding JSDOc and debug

* Succesfully submitting cart to TaxRate API

* Use TaxRate API for cart calcularions

* Eliminate files for unused Avalara API

* Capturing orders for SalesInvoice

* Properly recording orders

* Recording returns

* Work around "duplicate transaction" error.

* Record refunds

* Fix typo/eslint/JSDoc issues

* Add Geocoding package

* Add Geocoding package

* Geocoding is for chumps

* Run unit tests in CI

* Add Meteor method for discoverability

* Pull up the proper geocoding function and call it

* Convert method to synchronous

* Use latest version of library

* Lengthen timeout

* simple "pass/fail" validation via geocoding

* Add USPS zipcode verification library

* Add zipcode validation to addAccount

* Fix country code fix

* Fix validation results

* Make refunds committed

* Remove zipcode validation

* Remove zipcode package

* Use Avalara validation if enabled

* Destructure and restructure address to Avalara format

* Compare addresses item by item

* Show message when addresses don't match

* Substitute validated address for entered address, show warning.

* Set dropdown values

* Have "edit" addressbook also validate address

* When no address validators are enabled, skip it

* When no address validators are enabled, skip it

* Remove providerName key

* Change method of registering addressValidation methods based on Aaron's feedback

* Add enable/disable address validation

* Handle validation messages from validator when it has additional things to say about address

* Remove generic geocoding plugin

* Changes to edit form as well

* Handles cases where address validation is not supported for this country

* Fix issue with Avalara trying to calc tax when it's not enabled.

* Only pass in taxrate if it's defined and is a number

* Reenable all tests

* Protect against being passed in an undefined order

* Fixing tests

* Trying to fix tests

* Remove running unit test

* Up the timeout on the discounts test

* Fix issue with "Expected the after hook to return a value" message

* removed "form-control" class
* fix close button not showing in FireFox

* fix search modal display
* put grid alerts into same container

* fix spacing for visibility indicator
* Fix typo. Resolves #1828

* Also another place with same typo
* Use a direct import instead of a Meteor method and remove security check

* moved inventory adjustment into payment approval
* Added import for Meteor Accounts package.

- Also prevent Accounts (meteor) from colliding with Accounts (reaction
collection)

* Updated import order
@aaronjudd aaronjudd changed the base branch from release-0.19.0 to development February 17, 2017 18:50
@mikemurray mikemurray merged commit 9a126a0 into development Feb 21, 2017
@mikemurray mikemurray removed the review label Feb 21, 2017
@kieckhafer kieckhafer deleted the 1586-cart-product-link-doesnt-work branch February 23, 2017 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants