Marketplace shop settings #1939
Conversation
…merce/reaction into marketplace-shop-settings
| const selector = { | ||
| // ignore blank site | ||
| _id: { | ||
| $ne: "ddzuN2YPvgvx7rJS5" |
There was a problem hiding this comment.
It cannot be assumed that this is the default shop id.
There was a problem hiding this comment.
We have be updated this publication with observers now, which allow for transforms in seller data and are no longer ignoring any id. Will create a PR by tomorrow with that, and other core changes.
| import Blaze from "meteor/gadicc:blaze-react-component"; | ||
| import { Card, CardHeader, CardBody } from "/imports/plugins/core/ui/client/components"; | ||
|
|
||
| class SettingsCard extends Component { |
There was a problem hiding this comment.
@mikemurray are we working on something similar? I think we need to do a bit of gap/review here?
(oh, and, this is cool)
There was a problem hiding this comment.
This most probably is RC code here. We can update this PR if you think it fits RC's requirements from the description and screenshots. It's just a cleaner version of the shop > shop settings, and without the additional owner stuff.
… for admin for userId and shopObject`
Unable to resolve some modules: "react-bootstrap" in /Users/sn/dev/marketplace/imports/plugins/included/sms/client/components/smsSettings.js (web.browser)
…ed' when an order is shipped` Test was timing out due to an undefined order.
There was a problem hiding this comment.
This adds needed functionality around setting up and administering shops within a marketplace type shop. Nice work!
I'm not fully sold on using specific functions such as hasMarketplaceAccess and isMarketplaceGuest instead of a more universal role checker, but it's working for now, so let's merge and continue to improve as we define a better coding style guide for RC.
| Template.shopSelect.helpers({ | ||
| sellerShops() { | ||
| const currentShopId = Reaction.Router.getParam("shopId") || 0; | ||
| const selector = { |
There was a problem hiding this comment.
Add TODO: to remove this hardcoded blank site ignorer.
…op-settings-fixes Spencer marketplace shop settings fixes
Please review and merge #1934 before this PR.
This PR is mainly a tidy up of shop settings for sellers.
At the moment
Shop settingssit in the user Profile page, this was mainly for simplicity.In this PR we have:
Shop SettingsshortcutShop AddressfieldsBase Units of Measureto shop settingsTimezoneto shop settingssellerpermissions toOrdersshortcutThe following results are produced from this PR:
User Dropdown shortcuts
General Shop Settings
Shop Address