Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Route to onClick for search #1989

Merged
merged 3 commits into from
Mar 15, 2017
Merged

add Route to onClick for search #1989

merged 3 commits into from
Mar 15, 2017

Conversation

kieckhafer
Copy link
Member

Fixes #1959

Adds Route to onClick event of search item

@aaronjudd aaronjudd self-requested a review March 15, 2017 00:56
@aaronjudd
Copy link
Contributor

aaronjudd commented Mar 15, 2017

OK so, yes, this seems to have resolved getting the PDP when clicking the search result.

Maybe as a new issue, these search result views seem like they could use some love...
accounts
orders

Copy link
Contributor

@aaronjudd aaronjudd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, fixes search PDP click through.

Copy link
Contributor

@aaronjudd aaronjudd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested publishing, cloning, searching results, admin and user views.

@aaronjudd aaronjudd merged commit a3aa699 into development Mar 15, 2017
@aaronjudd aaronjudd removed the review label Mar 15, 2017
@aaronjudd aaronjudd deleted the ek-searchLinkFix branch March 15, 2017 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants