"Deny when out of stock" behavior improvements 1928 #2034

joykare · 2017-03-23T21:01:52Z

Resolves #1928

Description Part 1

If I have 5 in stock and I add 10 of something to my cart my quantity is reduced to 5 (which makes sense) but I don't receive any sort of alert that my quantity has been changed and the "Added to Cart" alert shows the original quantity, not the adjusted quantity. This could lead to user confusion. I feel like at one time there was an alert that said "Your quantity has been adjusted".

Test Steps

Set product variant quantity to 5
Add 10 products of the variant onto cart
Expect an alert showing that the original quantity has been adjusted.

Description Part 2

If I have 5 in stock and I add 10 to my cart my quantity is reduced to 5. If I add another 20, the total quantity is now 10. So the "Deny when out of stock" is only the affecting the quantity I can add to cart, not the quantity in my cart. So I could have 10 in my cart even though there are only 5 in-stock, which I would think is exactly what "Deny when out of stock" is trying to avoid.

Test Steps

Set product variant quantity to 5
Add 10 products of the variant onto cart
Expect that quantity has been reduced to 5 (An alert pops up for the adjustment)
Add another 10 products onto cart
Expect an error alert stating that your cart is full

…to development

brent-hoover · 2017-03-24T02:47:48Z

When follow the instructions in Test 1 I get the following error in the server console:

=> App running at: http://localhost:3000/
02:46:25.552Z ERROR Reaction: Quantity must be a number
  Error: Quantity must be a number
      at getErrorObject (packages/aldeed_collection2-core.js:480:15)
      at [object Object].doValidate (packages/aldeed_collection2-core.js:462:13)
      at [object Object].Mongo.Collection.(anonymous function) (packages/aldeed_collection2-core.js:214:25)
      at [object Object].Mongo.Collection.(anonymous function) [as update] (packages/dispatch_run-as-user.js:325:19)
      at [object Object].Meteor.methods.cart/addToCart (server/methods/core/cart.js:379:29)
      at packages/check.js:130:16
      at [object Object]._.extend.withValue (packages/meteor.js:1122:17)
      at Object.exports.Match._failIfArgumentsAreNotAllChecked (packages/check.js:129:41)
      at maybeAuditArgumentChecks (packages/ddp-server/livedata_server.js:1734:18)
      at packages/ddp-server/livedata_server.js:719:19
      at [object Object]._.extend.withValue (packages/meteor.js:1122:17)
      at packages/ddp-server/livedata_server.js:717:40
      at [object Object]._.extend.withValue (packages/meteor.js:1122:17)
      at packages/ddp-server/livedata_server.js:715:46
      at [object Object]._.extend.protocol_handlers.method (packages/ddp-server/livedata_server.js:689:23)
      at packages/ddp-server/livedata_server.js:559:43
02:46:25.554Z ERROR Reaction: [ { name: 'items.0.quantity', type: 'expectedNumber', value: NaN } ] 'Invalid keys. Error adding to cart.'

joykare · 2017-03-24T12:51:53Z

@zenweasel It should work now

aaronjudd · 2017-03-28T02:41:33Z

imports/plugins/included/product-detail-simple/client/containers/productDetailContainer.js


      if (quantity < 1) {
        quantity = 1;
      }

+      if (currentVariant.inventoryPolicy && quantity > currentVariant.inventoryQuantity && storedQuantity < currentVariant.inventoryQuantity) {
+        Alerts.inline("Your product quantity has been adjusted to the max quantity in stock", "warning", {


Should have a i18n translation.

aaronjudd · 2017-03-28T02:42:01Z

imports/plugins/included/product-detail-simple/client/containers/productDetailContainer.js

+      }
+
+      if (currentVariant.inventoryPolicy && totalQuantity > currentVariant.inventoryQuantity) {
+        Alerts.inline(`Sorry, cart contains maximum quantity of ${currentVariant.title}. Failed to add to cart.`, "error", {


Also needs i18n translation (and the alerts that follow).

Also the message is confusing. How does my cart contain the maximum quantity? We are denying because it's out of stock right? The message should reflect that somehow.

aaronjudd · 2017-03-28T02:45:10Z

imports/plugins/included/product-detail-simple/client/containers/productDetailContainer.js

 };

 function composer(props, onData) {
  const tagSub = Meteor.subscribe("Tags");
+  const cartSub = Meteor.subscribe("Cart", Meteor.sessionId);


Where is Meteor.sessionId coming from? (sessionId is a Reaction thing..fyi) Also the cart subscription is available, (for better or worse) as Reaction.Subscriptions.Cart, so you can just say if Reaction.Subscriptions.Cart.ready()

brent-hoover · 2017-03-28T07:49:26Z

So if my quantity is 10 and I add 8 I get the message "Your quantity has been reduced" that's great. However if I try to add an additional 3 (which I should be able to add two as there is 2 left) it just gives me the "Sorry you have the maximum amount in your cart" message which it shouldn't.

I also sort of wish this message was where the add to cart message was as I think people will get overwhelmed reading messages from different parts of the screen at the same time.

brent-hoover

Need a few more changes

brent-hoover · 2017-03-28T07:32:18Z

imports/plugins/included/product-detail-simple/client/containers/productDetailContainer.js

+      }
+
+      if (currentVariant.inventoryPolicy && totalQuantity > currentVariant.inventoryQuantity) {
+        Alerts.inline(`Sorry, cart contains maximum quantity of ${currentVariant.title}. Failed to add to cart.`, "error", {


Also the message is confusing. How does my cart contain the maximum quantity? We are denying because it's out of stock right? The message should reflect that somehow.

…commerce/reaction into joykare-inventory-tracking-1928

joykare · 2017-03-28T09:43:20Z

@zenweasel @aaronjudd changes made

aaronjudd · 2017-03-29T00:54:22Z

imports/plugins/core/checkout/client/index.js

@@ -15,6 +15,7 @@ import "./templates/cartPanel/cartPanel.html";
 import "./templates/cartPanel/cartPanel.js";

 import "./templates/checkout/addressBook/addressBook.html";
+import "./templates/checkout/addressBook/addressBook.js";


Browser console error:

Uncaught Error: Cannot find module './templates/checkout/addressBook/addressBook.js'

BlazeLayout warning: unknown template "coreLayout"

I just pulled this branch again and am not seeing that error

What can I say, I've reaction reset, et al, branch is up-to-date, and I'm pointing at the cause of the error right here... ¯_(ツ)_/¯

Nevermind, now I do

impactmass and others added 10 commits March 1, 2017 22:05

Show Sidebar shipping in checkout

325adc9

Set actionView after payment checkout step

b9c4f47

Hide sidebar on entry to profile page

071dffa

Merge origin development

4700cd0

Merge branch 'development' of github.com:reactioncommerce/reaction in…

cb54270

…to development

Merge branch 'development' of github.com:reactioncommerce/reaction in…

4287301

…to development

Add alert and checkout message when item quantities have been adjusted

77e81c1

Update errors to include when cart is already full

357d509

Actually deny when out of stock

8c840fc

Add more descriptive error messages

07dc11b

joykare added the review label Mar 23, 2017

joykare added 2 commits March 24, 2017 00:11

Merge branch 'development' of github.com:reactioncommerce/reaction in…

51c1473

…to development

Merge branch 'development' into joykare-inventory-tracking-1928

4d797a7

brent-hoover requested review from mikemurray and brent-hoover March 24, 2017 02:11

joykare added 2 commits March 24, 2017 14:46

Fix console error on Quantity

b1ca5b5

Fix PR arising issue on quantity

e4339cf

Aaron Judd added 2 commits March 27, 2017 19:08

Merge branch 'development' into joykare-inventory-tracking-1928

e271555

Merge branch 'development' into joykare-inventory-tracking-1928

896a3d3

aaronjudd suggested changes Mar 28, 2017

View reviewed changes

brent-hoover and others added 2 commits March 28, 2017 15:34

Merge branch 'development' into joykare-inventory-tracking-1928

3a33c26

Clean up a few edge cases

6efe0c8

brent-hoover requested changes Mar 28, 2017

View reviewed changes

brent-hoover removed the request for review from mikemurray March 28, 2017 08:12

joykare added 2 commits March 28, 2017 12:08

Add i18n translations

60e6891

Merge branch 'joykare-inventory-tracking-1928' of github.com:reaction…

6d6e665

…commerce/reaction into joykare-inventory-tracking-1928

Remove file changes different from development

9f109e6

brent-hoover approved these changes Mar 28, 2017

View reviewed changes

Merge branch 'development' into joykare-inventory-tracking-1928

85ed068

aaronjudd suggested changes Mar 29, 2017

View reviewed changes

joykare and others added 2 commits March 29, 2017 12:04

Remove all references to addressbook.js

d15edf5

Merge branch 'development' into joykare-inventory-tracking-1928

634975e

aaronjudd approved these changes Mar 29, 2017

View reviewed changes

aaronjudd merged commit fad6051 into development Mar 29, 2017

aaronjudd removed the review label Mar 29, 2017

aaronjudd deleted the joykare-inventory-tracking-1928 branch March 29, 2017 15:38

brent-hoover mentioned this pull request Apr 4, 2017

"Deny when out of stock" behavior improvements #1928

Closed

spencern mentioned this pull request Oct 11, 2017

Release 1.5.0 #3089

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

"Deny when out of stock" behavior improvements 1928 #2034

"Deny when out of stock" behavior improvements 1928 #2034

joykare commented Mar 23, 2017

brent-hoover commented Mar 24, 2017

joykare commented Mar 24, 2017

aaronjudd Mar 28, 2017

aaronjudd Mar 28, 2017

brent-hoover Mar 28, 2017

aaronjudd Mar 28, 2017 •

edited

Loading

brent-hoover commented Mar 28, 2017

brent-hoover left a comment

brent-hoover Mar 28, 2017

joykare commented Mar 28, 2017

aaronjudd Mar 29, 2017 •

edited

Loading

brent-hoover Mar 29, 2017

aaronjudd Mar 29, 2017

brent-hoover Mar 29, 2017

"Deny when out of stock" behavior improvements 1928 #2034

"Deny when out of stock" behavior improvements 1928 #2034

Conversation

joykare commented Mar 23, 2017

brent-hoover commented Mar 24, 2017

joykare commented Mar 24, 2017

aaronjudd Mar 28, 2017

Choose a reason for hiding this comment

aaronjudd Mar 28, 2017

Choose a reason for hiding this comment

brent-hoover Mar 28, 2017

Choose a reason for hiding this comment

aaronjudd Mar 28, 2017 • edited Loading

Choose a reason for hiding this comment

brent-hoover commented Mar 28, 2017

brent-hoover left a comment

Choose a reason for hiding this comment

brent-hoover Mar 28, 2017

Choose a reason for hiding this comment

joykare commented Mar 28, 2017

aaronjudd Mar 29, 2017 • edited Loading

Choose a reason for hiding this comment

brent-hoover Mar 29, 2017

Choose a reason for hiding this comment

aaronjudd Mar 29, 2017

Choose a reason for hiding this comment

brent-hoover Mar 29, 2017

Choose a reason for hiding this comment

aaronjudd Mar 28, 2017 •

edited

Loading

aaronjudd Mar 29, 2017 •

edited

Loading