Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve missing import #2132

Merged
merged 3 commits into from
Apr 18, 2017
Merged

Resolve missing import #2132

merged 3 commits into from
Apr 18, 2017

Conversation

brent-hoover
Copy link
Collaborator

Resolves #2112 🎸 🤘
Because sometimes I'd rather fix than triage.

Steps to test

  1. Start a fresh reaction
  2. Place an order with an invalid email so "resend" appears
  3. Click on "resend"
  4. Observe there is no error

@brent-hoover brent-hoover requested a review from kieckhafer April 18, 2017 02:35
@brent-hoover brent-hoover changed the title Brent fix issue 2112 Resolve missing import Apr 18, 2017
kieckhafer
kieckhafer approved these changes Apr 18, 2017
View reviewed changes
Copy link
Member

@kieckhafer kieckhafer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Email sends, no errors.

@kieckhafer kieckhafer merged commit ad16176 into development Apr 18, 2017
@kieckhafer kieckhafer removed the review label Apr 18, 2017
@kieckhafer kieckhafer deleted the brent-fix-issue-2112 branch April 18, 2017 16:42
@aaronjudd aaronjudd mentioned this pull request Apr 18, 2017
Merged
@brent-hoover brent-hoover mentioned this pull request Apr 20, 2017
Closed
@spencern spencern mentioned this pull request Oct 11, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kieckhafer kieckhafer kieckhafer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brent-hoover @kieckhafer