Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Marketplace shop switcher #2412

Merged
merged 9 commits into from
Jun 12, 2017
Merged

Marketplace shop switcher #2412

merged 9 commits into from
Jun 12, 2017

Conversation

spencern
Copy link
Contributor

@spencern spencern commented Jun 8, 2017

  • Adds a marketplace shop switcher to the admin toolbar.
  • Admins can see and switch between any shops for which they have any permissions.
  • Makes the product grid shop switcher work for changing between shops product grids for all users.
  • Switching shops changes the Reaction.shopId
  • Change Reaction.shopId into a ReactiveVar.
  • Add getter and setter for Reaction.shopId
  • Add closeOnClick option to DropDownMenu component

spencern added 9 commits June 6, 2017 09:29
@spencern
Remove unused media and tag db lookups
3b42ed1
@spencern
Give all users access to shop selector.
01c94a3 
* Modifies Shops publication to return all shops with matching domain by removing limit
* Rewrite of shop selector dropdown
* Use Shops publication instead of SellerShops publication in dropdown
* Remove requirement for marketplace ownership to see shop selector
* Change Reaction.ShopId when shop selector is changed
* TODO: Convert shop selector to React
@spencern
Set ShopId on shop selector change
ac4494a
@spencern
Merge branch 'spencer-code-cleanup' into marketplace-shop-switcher
8b3df17 
* Eliminates console warnings
@spencern
Regular Shop Selector should just adjust only the route.
44ed9bc
@spencern
Remove empty line at top of navbar
150514f
@spencern
Change Reaction.shopId to be a ReactiveVar
8947d2c
@spencern
Add closeOnClick option to DropDownMenu
9cc050d
@spencern
Add shop selector to admin toolbar.
6af82e8
@spencern spencern requested review from mikemurray and aaronjudd June 8, 2017 22:15
@spencern
Copy link
Contributor Author

spencern commented Jun 8, 2017

@mikemurray You helped write a lot of this React code, but can you double check the stuff that I did on my own in toolbar.js and toolbarContainer.js?

@aaronjudd Review for what you were thinking with Shop Selector?

@mikemurray
Copy link
Member

@spencern I think we should cherry pick the popover/dropdown changes we made and push them to development. Too good of an upgrade to those components to leave in this branch alone.

@spencern
Copy link
Contributor Author

spencern commented Jun 9, 2017

@mikemurray I can do that cherry pick and add a PR to dev

@spencern
Copy link
Contributor Author

spencern commented Jun 9, 2017

@mikemurray can you give a thumbs up on this review if my other React code was up to par?

mikemurray
mikemurray approved these changes Jun 9, 2017
View reviewed changes
Copy link
Member

@mikemurray mikemurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@aaronjudd aaronjudd merged commit e2d9335 into marketplace Jun 12, 2017
@aaronjudd aaronjudd deleted the marketplace-shop-switcher branch June 12, 2017 23:08
@spencern spencern mentioned this pull request Oct 11, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikemurray mikemurray mikemurray approved these changes

@aaronjudd aaronjudd aaronjudd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@spencern @mikemurray @aaronjudd