[Marketplace] Feature - getShopId server side #2435
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Modifies Shops publication to return all shops with matching domain by removing limit * Rewrite of shop selector dropdown * Use Shops publication instead of SellerShops publication in dropdown * Remove requirement for marketplace ownership to see shop selector * Change Reaction.ShopId when shop selector is changed * TODO: Convert shop selector to React
* Eliminates console warnings
…etShopId now checks for user selected shop
|
@lcampanis You may want to review this as well as this is the point where we're starting to move away from some of the I still like the idea of using the concept of "my shop" or sellerShop for some functionality, but at the core I think we need more flexibility from the |
|
Closing in favor of #2429 which has these changes and more pulled in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review and merge #2429 if it has not been merged yet first. Creating separate PRs and branches here even though they build off of each other to keep concerns separated.
This PR accomplishes the following
Reaction.setUserPreferenceReaction.getUserPreferencethat permits us to retrieve user preferences on the serverReaction.getShopIdon the server to accept a userId param and return the users activeShopId if it's setThis PR should be reviewed in depth for security vulnerabilities