[Marketplace] Owner permission should be transferable #2188 #2609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…reaction into seun-invite-owner-2186
…e/reaction into seun-migration-to-groups
12 tasks
impactmass
changed the title
impactmass
changed the title
impactmass
changed the title
spencern
approved these changes
Aug 4, 2017
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2188 (transfer of ownership of a Shop or Marketplace to another administrator)
How to test:
Transfering Marketplace Owner
_ In the default (primary) shop, log in as default admin and invite a user as shop admin (e.g Shop Manager).
_ On the newly invited user, click the group dropdown, and select "Owner"
_ Confirm that there's a pop up warning about the intended change
_ On proceeding, the current owner should be replaced with the new owner.
_ NB: The old owner (who is currently logged in) losses the right to change the owner back (since she has transferred ownership)
_ Log in as the new user that the ownership was transferred to (in new browser)
_ Go to the admin panel for that user, and confirm that you can transfer the ownership back
Test for another shop
_ Create a new shop. (e.g using the "Invite Owner Form" from the Marketplace tab in Shop settings)
_ Log in as the owner of the shop, and run through a similar process like above