Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PDP images not associated with variant/options #2711

Merged
merged 5 commits into from
Aug 22, 2017

Conversation

desaawa
Copy link
Contributor

@desaawa desaawa commented Aug 21, 2017

This fixes #2647

Steps to test

  1. As admin, select a variant option in PDP
  2. Click on the thumbnails to upload image for the variant.

basic_reaction_product

  1. Observe that the image is attached to the selected variant. And if you select another option, you should not see the image

basic_reaction_product2

@desaawa desaawa requested a review from aaronjudd August 21, 2017 11:15
Copy link
Contributor

@aaronjudd aaronjudd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This resolved the upload behavior for variants. It appears the broken "variant" layout in the product grid is a separate issue (and still broken).

@aaronjudd
Copy link
Contributor

@zenweasel since you disagreed (in theory) with this behaviour, can you take a look and see if it makes sense or not to you?

@brent-hoover
Copy link
Collaborator

Yeah, I think it makes sense once you realize you have to select the top-level variant to be able to modify the "product" image and that just "deselecting" the options does not allow you to set the top-level images.

@brent-hoover brent-hoover merged commit 78536e4 into marketplace Aug 22, 2017
@brent-hoover brent-hoover deleted the awa-fix-variant-images branch August 22, 2017 06:30
@spencern spencern mentioned this pull request Oct 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants