Fix order table RTL alignment #2876
Conversation
|
|
|
|
|
@rymorgan ready for another look. |
|
Great, took a look at the spacing, and that's fixed. |
|
@spencern this is ready for a review. |
|
@spencer you need to |
private/data/i18n/en.json
Outdated
| @@ -292,7 +292,18 @@ | |||
| "orderSetToState": "{{orderNumber}} {{orderText}} set to {{status}}", | |||
| "skippedBulkOrdersAlert": "You've requested that {{selectedOrders}} {{orderText}} be set to the '{{status}}' status, but {{numberOfSkippedOrders}} of these orders {{skippedOrdersText}} not in the '{{skippedState}}' state and would skip all steps leading up to the '{{status}}' state. Are you sure you want to do this?", | |||
| "bulkOrdersRegressionAlert": "You're about to regress {{ordersToRegress}} {{orderText}} back to the '{{status}}' state. Are you sure you want to continue with this operation?", | |||
| "paymentCaptureSuccess": "Payments successfully captured" | |||
| "paymentCaptureSuccess": "Payments successfully captured", | |||
| "table": { | |||
There was a problem hiding this comment.
We need to be putting these i18n definitions in the /server/i18n directory within the plugin and not in the project wide /private/data/i18n file. I'll fix this one, but let's make sure that from here on out, the i18n defs are in the plugins directory whenever they are used by a plugin
…thub.com:reactioncommerce/reaction into kieha-fix-order-table-translations-rtl-2817-2818
|
@kieha This is pretty much ready to merge, but the latest marketplace merge introduced a conflict. Can you resolve this when you get a chance? |
|
@spencern conflicts fixed. |
|
I'm still seeing one more conflict here in the browser @kieha |
|
@spencern fixed. Good to go. |
|
You're @-ing me not the Spencer you intended. (I've been ignoring it, but thought I should probably point it out)
|
spencern
deleted the
kieha-fix-order-table-translations-rtl-2817-2818
branch
Resolves #2818. Also, adds translations for order table headers.
How to test
P.S.
reaction resetfor the translations on the order table headers to take effect.