-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix alerts for confirmation when inviting new user #2937
Conversation
@jm-wanja Now that I've thought about this a little more, we should use a toast alert in this instance. It's a temporary alert and confirmation that the email has been sent. |
@rymorgan this is noted. Should we also use a toast alert for the |
@mikemurray @kieckhafer -- I'm changing my mind again on this. Do y'all have an opinion on the best UX here? Inline alert or toast alert confirmation when an invite email has been sent. |
I'm a fan of the toasts, as it's less intrusive and doesn't alter any of the existing display when it shows. |
The toast is probably better in this situation since it's a success, and you only need to see that it succeed for a second to "get it". |
@jm-wanja So, yes then let's go to toast for both here and invite owner. The caveat is that if there is an error, that needs to happen inline so that they know where the error is and how to correct it. |
@rymorgan I have implemented the new changes, toasts alerts for success and inline alert for error. I have done this for both invite admin and invite owner. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested. Verified fixed
Resolve #2928
How To Test