sync inventory policy toggle between top-level variants and child variants #3004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kieckhafer
changed the title
|
If we are showing the inventory control on the options, don't we also need to show the warn at field? |
kieckhafer
changed the title
brent-hoover
requested changes
Oct 3, 2017
| @@ -195,6 +199,44 @@ const wrapComponent = (Comp) => ( | |||
| Meteor.call("products/updateProductField", variant._id, "isVisible", !variant.isVisible); | |||
| } | |||
|
|
|||
| /** | |||
| * @method updateInventoryPolicyIfChildVariants | |||
| * @description update parent inventory policy if variant has children children | |||
There was a problem hiding this comment.
typo? "children children"
| const parent = ReactionProduct.getVariantParent(variant); | ||
|
|
||
| // If this is not a top-level variant, update top-level inventory policy as well | ||
| if (parent) { |
There was a problem hiding this comment.
Could we combine this into one conditional e.g. if (parent && options && options.length) ?
| @@ -6,6 +6,7 @@ import Velocity from "velocity-animate"; | |||
| import "velocity-animate/velocity.ui"; | |||
| import { Components } from "@reactioncommerce/reaction-components"; | |||
| import { formatPriceString } from "/client/api"; | |||
| import { Reaction } from "/lib/api"; | |||
There was a problem hiding this comment.
Imported but not used.
|
So is the default behavior supposed to be that if I create an option for a product it's "disabled" at the top level forever more? |
|
@zenweasel
yes |
brent-hoover
approved these changes
Oct 3, 2017
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2911
ReactionProduct.getSiblings()to get documents of a variantssiblings, who have the same ancestor treeReactionProduct.getParent()to get document of a variants direct parentIf a variant has no child variants, the toggle functionality is unchanged.
If a variant has child variants, the toggle is disabled on the top-level variant, and inherits the following value, based on it's children:
inventoryPolicy === false, meaning backorders are allowed, then the top-level variant will also be set toinventoryPolicy === falseinventoryPolicy === true, then the top-level variant will also be set toinventoryPolicy === true