Docker base and CircleCI updates #3045
Conversation
| if [[ "$CIRCLE_BRANCH" != "master" && \ | ||
| "$CIRCLE_BRANCH" != "development" && \ | ||
| "$CIRCLE_BRANCH" != *"docker"* && \ | ||
| "$CIRCLE_BRANCH" != "marketplace" ]]; # TODO: remove this once marketplace is merged |
There was a problem hiding this comment.
Should I wait to merge this until after we've released 1.5.0?
There was a problem hiding this comment.
I was under the impression the release-1.5.0 branch is marketplace. No?
There was a problem hiding this comment.
Either way, this will have no effect on whether marketplace continues to build in CI unless you merge release-1.5.0 back into marketplace.
There was a problem hiding this comment.
And we definitely want this to be part of the 1.5.0 release. The current Docker base isn't using the current 4.x version of Node that we should be (4.8.4).
|
I am merging into release-1.5.0 -> it's time to kill |
| @@ -11,6 +11,7 @@ jobs: | |||
| - DOCKER_VERSION: 17.05.0-ce | |||
| - DOCKER_COMPOSE_VERSION: 1.15.0 | |||
| - METEOR_ALLOW_SUPERUSER: true | |||
| - TOOL_NODE_FLAGS: "--max-old-space-size=4096" | |||
There was a problem hiding this comment.
any further reference on the memory issue / fix here?
There was a problem hiding this comment.
There is no update on the memory usage of the Meteor build tool. I think the real solution is just building a smaller app. And that's one of the focuses of our upcoming performance work on Reaction.
| docker push $DOCKER_NAMESPACE_DEV:latest | ||
| fi | ||
|
|
||
|
|
||
| # Master branch deployment (only runs when a version git tag exists - syntax: "v1.2.3") | ||
| if [[ "$CIRCLE_BRANCH" == "master" ]]; then | ||
| VERSION=$(git describe --tags | grep "^v[0-9]\+\.[0-9]\+\.[0-9]\+$") |
There was a problem hiding this comment.
hmm.. how do you guys handle tagging releases such as patch, hotfix, & the like?
There was a problem hiding this comment.
We tag release versions in the format v1.2.3. Doing so triggers a tagged release to Docker Hub.
The last item appears to fix #3023 when building on CircleCI without our build cache.