registerSchema() #3053
Merged
registerSchema() #3053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronjudd
reviewed
Oct 7, 2017
aaronjudd
approved these changes
Oct 7, 2017
|
@aaronjudd yes please. |
mikemurray
reviewed
Oct 7, 2017
| } | ||
|
|
||
| // store the component in the table | ||
| Schemas[name] = schema; |
There was a problem hiding this comment.
Should we match the style of registerComponent and do Schemas[name] = { name, schema } ?
- TODO: add back later + deps in 1.6.x
aaronjudd
suggested changes
Oct 7, 2017
There was a problem hiding this comment.
Not sure if BitHound is ever going to report back but you have some linting errors that need to be corrected. https://www.bithound.io/github/reactioncommerce/reaction/ek-issue2983/files#lint
|
@aaronjudd fixed. |
This reverts commit 7aabb1c.
aaronjudd
approved these changes
Oct 7, 2017
|
@aaronjudd merging because your approval + tests pass. |
This was referenced Oct 7, 2017
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2983
Documention here: reactioncommerce/reaction-docs#296
registerSchema()to register schemas in an object