add error message for inactive shops trying to connect to Stripe #3076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spencern
reviewed
Oct 10, 2017
| @@ -29,6 +29,10 @@ Template.stripeConnectSignupButton.events({ | |||
|
|
|||
| const shop = Shops.findOne({ _id: shopId }); | |||
|
|
|||
| if (!shop || !shop.workflow || shop.workflow.status !== "active") { | |||
There was a problem hiding this comment.
I think this is probably a good intermediate fix. Long run we should be building up the shops workflow and aligning UI with that so that buttons that are inactive are not even available on the UI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently do not show any error for
neworinactiveshops, when a user tries to click the "Start Accepting Payment" button on the Stripe connect settings. A user would click the button and nothing would happen.This update adds an error message to direct the user to contact the marketplace admin.
I've also moved a few translations into this package, as they were in a different package and didn't seem to be working.