-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use React components for footer and header #3257
Changes from all commits
779f1c9
0e0af4b
35ed3c3
75c8d15
4813a92
310e6ac
0c7367c
15d9e2b
f7b7aff
6e40ad7
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
This file was deleted.
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
import React from "react"; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Adding a footer requires design direction from @rymorgan since for the longest time, we've not had one displayed. And the question is, should we even be adding visible one now. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Footer should not be displayed anywhere, if it wasn't already before.. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. But then, a plugin would have its own requirements on how the Footer is supposed to be rendered. Maybe it's just unnecessary to have it in its own place. |
||
import { registerComponent } from "/imports/plugins/core/components/lib"; | ||
|
||
const Footer = () => ( | ||
<div className="reaction-navigation-footer footer-default"> | ||
<nav className="navbar-bottom" role="navigation"> | ||
<div className="row"> | ||
{/* Footer content */} | ||
</div> | ||
</nav> | ||
</div> | ||
); | ||
|
||
|
||
registerComponent("Footer", Footer); | ||
|
||
export default Footer; |
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any time these values change, you'll need to write a migration. This goes for all the
register.js
files modified.Migrations can be found in
/imports/plugins/core/versions
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks. I've written a migration for it.